Remove password requirement for setting up withdrawal account#5545
Conversation
MelvinBot
requested review from
jasperhuangg
and removed request for
a team
|
@jasperhuangg is at 20% this week so requesting another reviewer. The Auth PR has been merged so the code can be reviewed and tested on dev, waiting to remove the hold until after the auth deploy. |
|
Auth PR has been deployed, taking off hold |
Jag96
changed the title
|
@Jag96 Helloo! Following orders from QA steps and tagging you for QA 🙇 |
|
@Jag96, Is this possibly a regression? On dev, it seems like we're unable to go beyond step 2. The UI doesn't show any error for me but the network request says "401 error", @luacmartins tried the same on his end and got, |
|
Adding to this, I do see the UI error |
|
Btw i just tested this on staging and it doesn't have password field, and it clears through just fine on staging, I'm not sure why it failed on dev for me just yet. |
|
Okay, nvm me. I did an updateRepos all and makeAll and once i retested it worked fine for me on dev. |
|
Same here, just had to update all the repos! Sorry for the false alarm! |
|
🚀 Deployed to production by @chiragsalian in version: 1.1.4-0 🚀
|
8 participants
Details
Per this thread we want to remove the password requirement for adding a withdrawal account. This PR updates the UI to not include the password field for the
Company Step, and removes the password param for theBankAccount_SetupWithdrawalAPI call.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/179271
Tests
Get Startedto go through the VBA flow, follow https://stackoverflow.com/c/expensify/questions/342/525#525Company Informationstep, the password field doesn't appear
4. Confirm you can submit the form, and that there is no error regarding the passwordQA Steps
Tag @Jag96 and I can run through the QA steps for this on staging
Tested On
Screenshots
Screenshot in the tests section